WebGPU fixes #1293
Merged
WebGPU fixes #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
xenova
commented
Apr 23, 2025
Comment on lines
+458
to
+460
| // Only return the data if it's not a GPU buffer | ||
| unpacked.data = tensor.data; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Needed, otherwise another error is thrown because data is on GPU, not CPU, so we can't access it with .data without awaiting it's contents (not needed for an error message)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes multi-session management much easier, adding a global web inference lock to ensure only one session can run at any given time, preventing "Session has already started" errors.